-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #219, #93, Add EVS port timestamp and simplify port selection #2295
Conversation
Only failure is the overly restrictive commit message format check. Should there be a standard for commits that fix two issues? |
A couple comments:
|
I only need the format added. If someone requires additional formats they could address in a future issue.
I don't think this would help my specific need, wouldn't correlate to syslog timing or packet timestamps.
I only need it via config. If someone requires commandability they could address in a future issue. Good suggestions, but given my current requirements this change is all I need. Hopefully the future work can be independent from this ? |
I also want to get this week's award for addressing the oldest issue (2017!). So there's that :) |
@dzbaker @dmknutsen - Is there a CCB action on this one or is it pending review? |
@jphickey is just giving it a quick review to make sure there are no conflicts with other stuff being developed. It should be merged in at the end of this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general comment, in CFE/CFS we have lots of configuration options - configuration option overload, possibly - to the point that we cannot feasibly test them all.
I'm trying to think why we can't just add the time here, and make it "always on"? Is there a use-case where this would break someone's environment somehow? I don't think anyone would rely on not having a timestamp in event text. If we can avoid having yet-another-option that we can't test/maintain both ways, I'd rather just make this the new standard.
I'll do it! Much preferred from my perspective. |
@dmknutsen @jphickey - removed option to exclude timestamp in 43270f5 |
@jphickey @skliper @dmknutsen I can fast track this and include it in this next bundle if that makes sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it....
That being said, I dunno if this should close #93 ... The intent with that old idea is that EVS should call into the PSP for low level output. This is where you can make the 4 "output ports" go to different physical devices (depending on what the board has) and also attach different info per-port. That was the idea at least. Having 4 "output ports" in EVS without an mapping to the lower-level hardware seems to be an incomplete implementation of this, its been that way for years though. |
This is the one to move to the PSP (at least how I interpret them): 93 just cleans up how the bits are checked and paves the way for 94: |
Thanks, yes this makes sense. I'm OK with this closing #93. Maybe someday will get to implement #94 too, I'd still like to see that done. |
*Combines:* cFE v7.0.0-rc4+dev287 **Includes:** *cFE* - nasa/cFE#2306 - nasa/cFE#2295 - nasa/cFE#2303 - nasa/cFE#2312 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Haven Carlson <[email protected]>
*Combines:* cFE v7.0.0-rc4+dev287 **Includes:** *cFE* - nasa/cFE#2306 - nasa/cFE#2295 - nasa/cFE#2303 - nasa/cFE#2312 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Haven Carlson <[email protected]>
Checklist (Please check before submitting)
Describe the contribution
Testing performed
CI and on local build with time stamp enabled
Expected behavior changes
Adds time stamp when configured to do so
System(s) tested on
CI, Ubuntu 20.04
Additional context
Related but doesn't address (although should make the change simpler):
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC